Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for gcp-starter env, add assert with retry mechanism, and add deprecation warning in vector_service.proto #57

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

rohanshah18
Copy link
Contributor

Problem

When running tests with gcp-starter env. in java sdk, there were a couple of issues that needed to be addressed. In particular:

  1. Create and listIndexes wasn't working.
  2. Queries parameter was deprecated but the proto file wasn't updated with a warning.
  3. After upserting vectors into an index of gcp-starter env., there was some latency in querying the vectors which caused tests to fail.

Solution

This PR addresses the following:

  1. Fixed path for gcp-starter env to address the createIndex and listIndexes issue in gcp-starter env.
  2. Add deprecation tag for queries parameter of VectorRequest in vector_service.proto file.
  3. Added assert with retry mechanism function to make sure the tests are passing even though they fail for first couple of times. Given gcp-starter is a free-tier and not as performant as pod indexes, the retry mechanism will help ensure passing of the tests.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Ran integration tests suite.

@rohanshah18 rohanshah18 marked this pull request as ready for review January 10, 2024 23:10
Copy link

@haruska haruska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't execute this locally but the changes look ok.

src/main/proto/vector_service.proto Show resolved Hide resolved
@rohanshah18 rohanshah18 merged commit 14224b6 into main Jan 11, 2024
8 checks passed
@rohanshah18 rohanshah18 deleted the rshah/fixPath branch January 11, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants